Remove netcdf pin, and iris-grib dependency.#29
Closed
pp-mo wants to merge 1 commit intoconda-forge:masterfrom
Closed
Remove netcdf pin, and iris-grib dependency.#29pp-mo wants to merge 1 commit intoconda-forge:masterfrom
pp-mo wants to merge 1 commit intoconda-forge:masterfrom
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
ocefpaf
reviewed
May 29, 2018
| - cf_units | ||
| - dask >=0.17.1 | ||
| - matplotlib | ||
| - netcdf4 <1.4 |
Member
There was a problem hiding this comment.
I'd love to see this change in upstream's CI first. I have a branch (I'll commit it soon, I was waiting on SciTools/iris#3016 which is blocked b/c of SciTools/nc-time-axis#35) that show some errors when using netcdf4 >=1.4 with iris.
ocefpaf
reviewed
May 29, 2018
| - pyke | ||
| - scipy | ||
| - six | ||
| - iris-grib # [not (win or py3k)] |
Member
There was a problem hiding this comment.
I actually love to see this go away but when I removed it in the past I believe someone from SciTools requested me to put it back.
Member
|
It turns out we need SciTools/iris#3016 to make this work 😉 |
Member
|
Done in #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest netcdf should now be ok, since we now have cf_units 2.0 (see earlier comment saying that ).
Iris-grib should not be counted as a dependency; it is a strictly optional extra.